left pane nav panel extending all the way to the top#402
Conversation
paulbettner
changed the title
Thanks for the PR @paulbettner , I see an issue, toggling the sidebar multiple times causes it become empty |
paulbettner
force-pushed
the
pr/sidebar-titlebar-nav
branch
from
aad49a2 to
08d849c
Compare
|
Argh! I'm so sorry to bother you with a bug on my first PR, @saeedvaziry! I just pushed a fix to this and one other issue I found with more rigorous code review. Thanks for your time/consideration! |
|
No worries. I try to test every possible details. 
Somehow the PR has other regressions as well. |
|
One moren thing, the sidebar toggle animation has been removed. any reason? it was sliding to close before |
|
Just found and fixed that issue. I hadn't used the app enough to notice that animation was missing, I'm sorry! It's my daily driver now though, so I promise I'll get better at doing work in the codebase. Thanks for your patience 🙏 |
|
@paulbettner I need to push some changes to your branch on this PR. would you mark the PR as maintainers can edit? it says I am not allowed to push |
2 participants
Currently the top tab navigation bar extends above the left-hand workspace navigation panel, even though those tabs actually exist within the selected workspace. So I made an adjustment to "fix" this, extending the navigation panel so that it goes to the top of the window.
This is an opinionated UI PR, so please feel free to ignore it... but it makes more sense to me, visually, so I figured I'd submit this PR for your consideration.
Before:
After (this is from my fork):